added Z2 integer support by a-b-h-a-y-s-h-i-n-d-e · Pull Request #42 · deepforestsci/physika

a-b-h-a-y-s-h-i-n-d-e · 2026-04-03T12:25:59Z

This PR adds support for Z2 modulo 2 integer, along with support for XOR, AND operations and boolean flags

example code:

a: Z2 = 1
b: Z2 = 0

# XOR
a + b

# AND
a * b

JoseAntonioSiguenza · 2026-04-10T02:59:31Z

Please provide a brief description of changes

JoseAntonioSiguenza · 2026-04-10T03:00:32Z

+# Draft version class
+
+
+class Z2:


Please add docstrings and type annotations

JoseAntonioSiguenza · 2026-04-13T17:33:06Z

+
+    Examples
+    --------
+    >>> a = Z2(1)


Please add imports from physika

JoseAntonioSiguenza · 2026-04-13T17:33:42Z

+
+        Returns
+        -------
+        None


According to type annotations this returns "Z2", please fix

JoseAntonioSiguenza · 2026-04-13T17:34:26Z

+        """
+        return bool(self.val)
+
+    def __int__(self) -> int:


I think there are two init methods.

it is __int__ method, but now I have removed because we want both types to be Z2 only for doing operations.

JoseAntonioSiguenza · 2026-04-13T17:34:47Z

@@ -0,0 +1,121 @@
+from typing import Union


Please add unit ttests

rbharath

@a-b-h-a-y-s-h-i-n-d-e Make sure to add rst docs of the new features explaining and providing examples

a-b-h-a-y-s-h-i-n-d-e · 2026-04-15T10:27:05Z

JoseAntonioSiguenza · 2026-04-20T16:23:04Z

+# ----------------
+# XOR operation
+# ----------------
+xor_opposite = a + b


please add the types of these decl expressions: xor_opposite, xor_same, and_mixed, etc

JoseAntonioSiguenza · 2026-04-20T16:26:26Z

+import torch.optim as optim
+
+from physika.runtime import physika_print
+from physika.z2 import Z2


I'm not sure if we want physika.z2 as an import in runtime, instead as a physika type to perform modulo operations with.

yes this make sense, should I create a new type for Z2 just like we are doing in utils/types.py
e.g:

# Ground scalar types T_REAL = TScalar("ℝ") T_NAT = TScalar("ℕ") T_COMPLEX = TScalar("ℂ") T_STRING = TScalar("string")

and then handle explicitly in utils/type_checker_utils.py

@JoseAntonioSiguenza can you check the last commit which I made, I have added Z2 as a standalone type, but since we have z2.py I have to add that in runtime, but in generated code it is not getting included now

I think is better now Z2 as it type, please lets integrate this new type with exisiting ones and test it for type checker.

Maybe a new PR for type system integration is better to keep this PR with less changes

JoseAntonioSiguenza · 2026-04-22T14:39:22Z

        return T_COMPLEX
    if ts == "string":
        return T_STRING
+    if ts in ("ℤ2", "Z2"):


Please include this at test_type_checker_utils.py

JoseAntonioSiguenza · 2026-04-22T14:40:03Z

 T_NAT = TScalar("ℕ")
 T_COMPLEX = TScalar("ℂ")
 T_STRING = TScalar("string")
+T_Z2 = TScalar("ℤ2")


Please add this new type to existing tests

a-b-h-a-y-s-h-i-n-d-e · 2026-04-22T15:38:58Z

@JoseAntonioSiguenza , I have also added Z2 in Types section in language.rst file, we do have separate Z2 examples in same file

JoseAntonioSiguenza · 2026-04-24T14:59:30Z

 import torch.optim as optim

 from physika.utils.print_utils import _from_torch, _infer_type
+from physika.z2 import Z2  # noqa


So, I think having just this is not adding much. Lets remove Z2 from runtime completly (we can call later if needed)

JoseAntonioSiguenza · 2026-04-24T15:00:37Z

Great work!! This PR got pretty large, so lets split in 2 to facilitate final review:

main Z2 changes PR
Z2 type integration PR

a-b-h-a-y-s-h-i-n-d-e force-pushed the Z2_type branch 2 times, most recently from d6b0a34 to 684f2df Compare April 9, 2026 15:43

JoseAntonioSiguenza reviewed Apr 10, 2026

View reviewed changes

JoseAntonioSiguenza reviewed Apr 13, 2026

View reviewed changes

rbharath reviewed Apr 13, 2026

View reviewed changes

a-b-h-a-y-s-h-i-n-d-e force-pushed the Z2_type branch from 174db47 to 3d66805 Compare April 14, 2026 22:11

a-b-h-a-y-s-h-i-n-d-e changed the title ~~[DRAFT] added Z2 integer support~~ added Z2 integer support Apr 15, 2026

a-b-h-a-y-s-h-i-n-d-e force-pushed the Z2_type branch from 61bc381 to 5af89bc Compare April 16, 2026 14:55

JoseAntonioSiguenza reviewed Apr 20, 2026

View reviewed changes

a-b-h-a-y-s-h-i-n-d-e force-pushed the Z2_type branch from 5af89bc to 24bdfd1 Compare April 20, 2026 19:16

JoseAntonioSiguenza reviewed Apr 22, 2026

View reviewed changes

a-b-h-a-y-s-h-i-n-d-e added 11 commits April 23, 2026 00:06

added Z2 integer support

eaa6a45

updated z2.py file with docstrings

58841be

minor fixes: added type annotations in z2.py file

d9e048a

updated physika example code and some changes in z2.py docstrings

467e81d

added unit tests for z2.py file

2ccbd38

minor fixes: fixed mypy issues and improved the physika file

97b66f3

added docs and updated torch and ast code

d7bc849

updated physika code with types and added __int__ in z2 class

c17c02a

minor fixes: fixed failing tests

a008529

added Z2 as T_Z2 type

9959d04

added unit tests for Z2 type

cf90efb

udpated language.rst to add Z2 type example

581104f

a-b-h-a-y-s-h-i-n-d-e force-pushed the Z2_type branch from 84a0fa7 to 581104f Compare April 22, 2026 18:36

JoseAntonioSiguenza reviewed Apr 24, 2026

View reviewed changes

Conversation

a-b-h-a-y-s-h-i-n-d-e commented Apr 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JoseAntonioSiguenza commented Apr 10, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rbharath left a comment

Choose a reason for hiding this comment

Uh oh!

a-b-h-a-y-s-h-i-n-d-e commented Apr 15, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

a-b-h-a-y-s-h-i-n-d-e Apr 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

a-b-h-a-y-s-h-i-n-d-e commented Apr 22, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

JoseAntonioSiguenza commented Apr 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

a-b-h-a-y-s-h-i-n-d-e commented Apr 3, 2026 •

edited

Loading

a-b-h-a-y-s-h-i-n-d-e Apr 22, 2026 •

edited

Loading

JoseAntonioSiguenza commented Apr 24, 2026 •

edited

Loading