Skip to content

CI fixes#193

Merged
rbharath merged 2 commits into
mainfrom
lint-az-py-fixes
Apr 24, 2026
Merged

CI fixes#193
rbharath merged 2 commits into
mainfrom
lint-az-py-fixes

Conversation

@shreyasvinaya
Copy link
Copy Markdown
Collaborator

@shreyasvinaya shreyasvinaya commented Apr 6, 2026

Description

fixes a bunch of typechecks and docs build

Type of change

Please check the option that is related to your PR.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
    • In this case, we recommend to discuss your modification on GitHub issues before creating the PR
  • Documentations (modification for documents)

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New unit tests pass locally with my changes
  • I have checked my code and corrected any misspellings

Copy link
Copy Markdown
Contributor

@rbharath rbharath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please separate into two PRs. One for lint, one for az. Don't have different changes in same PR

@shreyasvinaya
Copy link
Copy Markdown
Collaborator Author

Split done: #193 now contains only the lint/docs-import cleanup, and the AZ changes were moved to #196.

@shreyasvinaya shreyasvinaya changed the title Lint az py fixes Lint fixes Apr 13, 2026
Copy link
Copy Markdown
Collaborator

@riya-singh28 riya-singh28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ARY2260 I have done a basic check. LGTM. Can you please do a second pass?

Copy link
Copy Markdown
Collaborator

@ARY2260 ARY2260 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ARY2260
Copy link
Copy Markdown
Collaborator

ARY2260 commented Apr 23, 2026

@shreyasvinaya Also this PR seems very small and vague as you don't not seem to fix much linting in this PR either. Can you please add a better description?

@shreyasvinaya shreyasvinaya changed the title Lint fixes CI fixes Apr 23, 2026
@rbharath rbharath merged commit ddab49d into main Apr 24, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants