Open
Conversation
Signed-off-by: Konstantin Kozoriz <konstantin.kozoriz@flant.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Problem
When
d8 data export downloadord8 data import uploadcommands encounter a not-ready resource, the error message is generic and unhelpful - e.g.,DataExport ns/name is not Ready. Users have no way to understand the root cause (timeout, misconfiguration, controller issue, etc.) and cannot take corrective action.Additionally, during the retry loop (up to 60 attempts), there is no intermediate feedback - the command appears to hang silently until it either succeeds or fails after ~3 minutes.
Solution
MessageandReasonfields in all "not Ready" error messages for bothDataExportandDataImportresources. The error now reads:DataExport ns/name is not Ready: <message> (<reason>).GetDataExportWithRestartandGetDataImportWithRestart, so users can see the current status and attempt number while waiting.Before fix
After fix