Skip to content

feat: i18n#182

Merged
dec0dOS merged 8 commits into
dec0dOS:mainfrom
aruznieto:i18n
Oct 19, 2023
Merged

feat: i18n#182
dec0dOS merged 8 commits into
dec0dOS:mainfrom
aruznieto:i18n

Conversation

@aruznieto

@aruznieto aruznieto commented Oct 16, 2023

Copy link
Copy Markdown
Contributor

Add i18n capability.

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build-related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: #137

Does this introduce a breaking change?

  • Yes
  • No

Other information

Actually I trying to add the possibility to change the language.

Comment thread backend/routes/auth.js Outdated
@aruznieto

aruznieto commented Oct 17, 2023

Copy link
Copy Markdown
Contributor Author

Added settings page (no tested on a computer with a different than Spanish or English). Maybe you should consider to remove all console.logs on all platform or enable it only on debug mode, nor production

@aruznieto

aruznieto commented Oct 17, 2023

Copy link
Copy Markdown
Contributor Author

https://crowdin.com/project/zero-ui

We can talk on Discord/Telegram if u want

@aruznieto aruznieto mentioned this pull request Oct 18, 2023
9 tasks
@aruznieto aruznieto marked this pull request as ready for review October 18, 2023 08:00
Comment thread frontend/public/locales/en/common.json
Comment thread frontend/public/locales/en/common.json Outdated
Comment thread frontend/public/locales/en/common.json Outdated
Comment thread frontend/public/locales/en/common.json Outdated
Comment thread frontend/src/components/HomeLoggedIn/HomeLoggedIn.jsx Outdated
Comment thread frontend/src/components/SettingsComponent/SettingsComponent.jsx Outdated
Comment thread frontend/src/i18n.js Outdated
Comment thread frontend/src/components/SettingsComponent/SettingsComponent.jsx
Comment thread frontend/src/components/SettingsComponent/SettingsComponent.jsx
Comment thread frontend/src/routes/Settings/Settings.jsx Outdated
@dec0dOS

dec0dOS commented Oct 19, 2023

Copy link
Copy Markdown
Owner

https://crowdin.com/project/zero-ui

We can talk on Discord/Telegram if u want

I would like to know more about the crowdin platform. Please share your contacts.

@dec0dOS

dec0dOS commented Oct 19, 2023

Copy link
Copy Markdown
Owner

Added settings page (no tested on a computer with a different than Spanish or English). Maybe you should consider to remove all console.logs on all platform or enable it only on debug mode, nor production

Removing the console.log statements from the frontend doesn't offer any significant benefits. ZeroUI is primarily used by administrators, not average users. Logs can be quite helpful in identifying and resolving issues, so removing them doesn't really contribute to the improvement of the platform in any way

@aruznieto

Copy link
Copy Markdown
Contributor Author

https://crowdin.com/project/zero-ui

We can talk on Discord/Telegram if u want

I would like to know more about the crowdin platform. Please share your contacts.

Same username that here. @aruznieto (tg)

@dec0dOS

dec0dOS commented Oct 19, 2023

Copy link
Copy Markdown
Owner

Same username that here. @aruznieto (tg)

Right now, I'm a bit tied up, but I'll reach out to you later

@dec0dOS dec0dOS left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment thread frontend/public/locales/en/common.json Outdated
Comment thread frontend/public/locales/en/common.json Outdated

@dec0dOS dec0dOS left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2023-10-19 at 13 58 59
Screenshot 2023-10-19 at 13 59 03
Screenshot 2023-10-19 at 13 59 11
Screenshot 2023-10-19 at 13 59 28
Screenshot 2023-10-19 at 13 59 19

@dec0dOS

dec0dOS commented Oct 19, 2023

Copy link
Copy Markdown
Owner

Screenshot 2023-10-19 at 14 01 56

@aruznieto

Copy link
Copy Markdown
Contributor Author

I think now all is done.

@dec0dOS

dec0dOS commented Oct 19, 2023

Copy link
Copy Markdown
Owner

LGTM

@dec0dOS dec0dOS merged commit 4a5f846 into dec0dOS:main Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants