Y Axes alignment option: addendum#1033
Closed
gazal-k wants to merge 4 commits into
Closed
Conversation
separated the code for aligning axes into function alignYAxisRanges to reduce cyclomatic complexity
Closed
Contributor
|
Just as a progress report, I'm merging this in the hotfix/2.0.0-beta.32 branch. Here is a matrix of the 25 cases which I'm adding as an example and visual test case. (There are at least 25 cases because left and right can each be all positive, mostly positive, even positive/negative, mostly negative, or all negative.)
Looks like the current heuristic gets many cases well, but severely squishes one series or the other in about 8 cases, and loses one or the other in two cases. I'm going to try a more comprehensive approach. |
gordonwoodhull
added a commit
that referenced
this pull request
Jul 18, 2016
gordonwoodhull
added a commit
that referenced
this pull request
Jul 19, 2016
gordonwoodhull
added a commit
that referenced
this pull request
Jul 28, 2016
Contributor
|
Improved algorithm: |
Contributor
|
Live in 2.0 beta 32. Thanks @gazal-k! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #985