dbeaver/pro#9170 adds download button for the script#4474
Open
sergeyteleshev wants to merge 6 commits into
Open
dbeaver/pro#9170 adds download button for the script#4474sergeyteleshev wants to merge 6 commits into
sergeyteleshev wants to merge 6 commits into
Conversation
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 15 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
devnaumov
reviewed
Jul 20, 2026
|
|
||
| function handleSaveToFile() { | ||
| const blob = new Blob([state.query], { type: 'text/plain' }); | ||
| download(blob, getFileName([payload.nodeName, payload.generatorName])); |
Member
There was a problem hiding this comment.
please use withTimestamp(payload.nodeName)
| } | ||
|
|
||
| function handleSaveToFile() { | ||
| const blob = new Blob([state.query], { type: 'text/plain' }); |
Member
There was a problem hiding this comment.
const blob = new Blob([state.query], { type: 'application/sql' });
| } | ||
| } | ||
|
|
||
| function getEntityNameFromNodePath(nodePath: string | undefined): string | undefined { |
Member
There was a problem hiding this comment.
Its better to get node entity by nodePath and use node.name or you can use model.name
devnaumov
previously approved these changes
Jul 21, 2026
SychevAndrey
previously approved these changes
Jul 22, 2026
devnaumov
previously approved these changes
Jul 22, 2026
sergeyteleshev
dismissed stale reviews from SychevAndrey and devnaumov
via
July 22, 2026 17:57
7e2b2e0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes https://github.com/dbeaver/pro/issues/9170