Fix voice state machine bug in refactored helper functions#31
Merged
davidirvine merged 1 commit intodevelopfrom Jul 21, 2025
Merged
Fix voice state machine bug in refactored helper functions#31davidirvine merged 1 commit intodevelopfrom
davidirvine merged 1 commit intodevelopfrom
Conversation
The issue was in the update_voice_state helper function which was re-reading the voice state instead of using the current state passed from the main processing loop. This caused the voice to get stuck in PENDING_TRANSIT_TO_TARGET state instead of properly transitioning through IN_TRANSIT_TO_TARGET to AT_TARGET. Changes: - Modified update_voice_state to accept current_state parameter - Fixed enum references to use DeepnoteVoice::STATE instead of voice.STATE - All tests now pass (10 passed, 0 failed)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The issue was in the update_voice_state helper function which was re-reading the voice state instead of using the current state passed from the main processing loop. This caused the voice to get stuck in PENDING_TRANSIT_TO_TARGET state instead of properly transitioning through IN_TRANSIT_TO_TARGET to AT_TARGET.
Changes: