fix: tone down aggressive compiler flags to work with external depend…#30
Merged
davidirvine merged 1 commit intodevelopfrom Jul 21, 2025
Merged
fix: tone down aggressive compiler flags to work with external depend…#30davidirvine merged 1 commit intodevelopfrom
davidirvine merged 1 commit intodevelopfrom
Conversation
…encies - Remove -Werror and -Wpedantic to avoid failures from external code - Add more warning exclusions for common issues in external dependencies - Remove sanitizers from default debug build to reduce development friction - Keep reasonable warnings (-Wall -Wextra) for our own code quality This allows the project to build successfully while still maintaining good code quality standards for the main codebase.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…encies
This allows the project to build successfully while still maintaining good code quality standards for the main codebase.