Who Treatment Outcome TB and HIV#1937
Open
HarishC727 wants to merge 2 commits intodatacommonsorg:masterfrom
Open
Who Treatment Outcome TB and HIV#1937HarishC727 wants to merge 2 commits intodatacommonsorg:masterfrom
HarishC727 wants to merge 2 commits intodatacommonsorg:masterfrom
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a new statvar import for WHO Tuberculosis treatment outcomes among people living with HIV, including a data download script, manifest, and mapping files. The reviewer feedback highlights a redundant network request in the Python script, incorrect indicator URLs in the documentation and manifest, and several formatting issues such as trailing spaces and missing trailing newlines across multiple files.
statvar_imports/who_tuberculosis/treatmentoutcome_tb_hiv/tb_data_download_who.py
Outdated
Show resolved
Hide resolved
statvar_imports/who_tuberculosis/treatmentoutcome_tb_hiv/metadata.csv
Outdated
Show resolved
Hide resolved
statvar_imports/who_tuberculosis/treatmentoutcome_tb_hiv/tb_data_download_who.py
Show resolved
Hide resolved
statvar_imports/who_tuberculosis/treatmentoutcome_tb_hiv/tuberculosis_outcome_pvmap.csv
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR checklist