Skip to content

Tweak NPM#28

Merged
kravets-levko merged 2 commits into
databricks:masterfrom
kravets-levko:tweak-npm-publish
Jul 12, 2022
Merged

Tweak NPM#28
kravets-levko merged 2 commits into
databricks:masterfrom
kravets-levko:tweak-npm-publish

Conversation

@kravets-levko
Copy link
Copy Markdown
Contributor

  1. Publish only necessary files (package.json, readme, licence, dist/, and thrift/)
  2. Automatically run build script before publishing to ensure that contents of dist/ is fresh and matches sources
  3. Remove dist/ from VCS as it's now created when needed

Copy link
Copy Markdown
Contributor

@moderakh moderakh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love this PR. This is great to let npm takes care of creating the files rather than manually check them in and updating them in each PR. Thanks @kravets-levko

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants