Skip to content

Prepend slash to path if needed #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kravets-levko merged 3 commits into from
Jul 12, 2022
Merged

Prepend slash to path if needed #27

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
64111a5
[databricks/databricks-sql-nodejs#18] Prepend slash to path if needed
kravets-levko Jul 12, 2022
c8663c1
Build
kravets-levko Jul 12, 2022
b6c28ca
Merge branch 'master' into 18-prepend-slash-to-path
kravets-levko Jul 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion lib/DBSQLClient.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,13 @@ interface IDBSQLClient {
close(): void;
}

function prependSlash(str: string): string {
if (str.length > 0 && str.charAt(0) !== '/') {
return `/${str}`;
Copy link
Copy Markdown
Contributor

@yunbodeng-db yunbodeng-db Jul 12, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose there is no trimming business here? Someone has sanitized the path before?

Copy link
Copy Markdown
Contributor Author

@kravets-levko kravets-levko Jul 12, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No trimming. Slash is required in path, so we just add it when missing; if it's already there - we do nothing

}
return str;
}

export default class DBSQLClient implements IDBSQLClient, EventEmitter {
static utils = new HiveUtils(TCLIService_types);

Expand All @@ -37,7 +44,7 @@ export default class DBSQLClient implements IDBSQLClient, EventEmitter {
host: options.host,
port: options.port || 443,
options: {
path: options.path,
path: prependSlash(options.path),
https: true,
},
},
Expand Down