Update SDK to OpenAPI spec + Fix tests

[tanmay-db]

Changes

SDK generation and fixing tests by passing a request when calling ListAll method

Tests

Successfully generated + Integration tests passed except 2 tests in aws-prod-acct due to Credentials limit exceeded

• make test passing
• make fmt applied
• relevant integration tests applied

[codecov-commenter]

Codecov Report

Attention: 78 lines in your changes are missing coverage. Please review.

Comparison is base (508cfd5) 17.97% compared to head (a94da91) 17.93%.

Files	Patch %	Lines
service/catalog/api.go	0.00%	35 Missing ⚠️
service/catalog/model.go	0.00%	16 Missing ⚠️
experimental/mocks/mock_workspace_client.go	20.00%	12 Missing ⚠️
service/settings/api.go	0.00%	6 Missing ⚠️
service/settings/impl.go	0.00%	3 Missing ⚠️
service/catalog/impl.go	0.00%	2 Missing ⚠️
service/iam/model.go	0.00%	2 Missing ⚠️
service/sql/model.go	0.00%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #755      +/-   ##
==========================================
- Coverage   17.97%   17.93%   -0.04%     
==========================================
  Files         108      108              
  Lines       14649    14698      +49     
==========================================
+ Hits         2633     2636       +3     
- Misses      11802    11848      +46     
  Partials      214      214              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[tanmay-db]

[Discussion]

This is a breaking change (as golang doesn't support optional parameters) so we will have to mention this explicitly in our release notes or revert the original change in openapi spec for not introducing this.

We could do this change since Go SDK isn't GA yet but it won't be a good user experience i.e sending empty request.

Other non breaking alternatives are:

• Make ListAll as variadic on ListExternalLocationsRequest. Not sure if this is supported in SDK generator + if there are other different types of parameters in future for this method, then there might be more difficulties in maintenance.

func ListAll(ctx context.Context, requests ...ListExternalLocationsRequest) ([]ExternalLocationInfo, error) {
}

• Have a wrapper over ListAll -- but this is something we would have to maintain externally.

Both of these are something that we could do to not have breakage. This type of problem is specific to golang and could arise for other methods as well so we would need a solution that will work for other such cases as well without extra overhead.

What do you think? @miles @hectorcast-db

[tanmay-db]

+ @pietern for visibility as CLI release is blocked on GoSDK release.

[tanmay-db]

If we decided to not revert the open api change: Java SDK: databricks/databricks-sdk-java#204. There are some issues with Python SDK -- will take a look at them tomorrow.

[hectorcast-db]

Right now, since it's not GA we could go forward. List APIs should have pagination, so this is a good change.
But indeed, in general, adding an optional parameter to an API should not be a breaking change.

[hectorcast-db]

• @andrewnester Blocking issue for the release

[mgyucht]

Need to make sure .gitattributes is not regressing here.