Skip to content

Change Create Recipient CLI to use global metastore ID #534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pietern merged 4 commits into from
Aug 12, 2022
Merged

Change Create Recipient CLI to use global metastore ID #534

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1119681
initial
wchau Aug 11, 2022
00cb7e8
lint
wchau Aug 11, 2022
5c514f1
sharing_id
wchau Aug 11, 2022
de33148
.
wchau Aug 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions databricks_cli/unity_catalog/api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,8 +192,8 @@ def update_share_permissions(self, name, perm_spec):

# Recipient APIs

def create_recipient(self, name, comment, sharing_code, allowed_ip_addresses):
return self.client.create_recipient(name, comment, sharing_code, allowed_ip_addresses)
def create_recipient(self, name, comment, sharing_id, allowed_ip_addresses):
return self.client.create_recipient(name, comment, sharing_id, allowed_ip_addresses)

def list_recipients(self):
return self.client.list_recipients()
Expand Down
8 changes: 4 additions & 4 deletions databricks_cli/unity_catalog/delta_sharing_cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,8 +183,8 @@ def delete_share_cli(api_client, name):
@click.option('--name', required=True, help='Name of new recipient.')
@click.option('--comment', default=None, required=False,
help='Free-form text description.')
@click.option('--sharing-code', default=None, required=False,
help='A one-time sharing code shared by the data recipient offline.')
@click.option('--sharing-id', default=None, required=False,
help='The sharing identifier provided by the data recipient offline.')
@click.option('--allowed_ip_address', default=None, required=False, multiple=True,
help=(
'IP address in CIDR notation that is allowed to use delta sharing. '
Expand All @@ -193,12 +193,12 @@ def delete_share_cli(api_client, name):
@profile_option
@eat_exceptions
@provide_api_client
def create_recipient_cli(api_client, name, comment, sharing_code, allowed_ip_address):
def create_recipient_cli(api_client, name, comment, sharing_id, allowed_ip_address):
"""
Create a new recipient.
"""
recipient_json = UnityCatalogApi(api_client).create_recipient(
name, comment, sharing_code, allowed_ip_address)
name, comment, sharing_id, allowed_ip_address)
click.echo(mc_pretty_format(recipient_json))


Expand Down
6 changes: 3 additions & 3 deletions databricks_cli/unity_catalog/uc_service.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -376,15 +376,15 @@ def update_share_permissions(self, name, perm_spec, headers=None):

# Recipient Operations

def create_recipient(self, name, comment=None, sharing_code=None,
def create_recipient(self, name, comment=None, sharing_id=None,
allowed_ip_addresses=None, headers=None):
_data = {
'name': name,
}
if comment is not None:
_data['comment'] = comment
if sharing_code is not None:
_data['sharing_code'] = sharing_code
if sharing_id is not None:
_data['data_recipient_global_metastore_id'] = sharing_id
_data['authentication_type'] = 'DATABRICKS'
else:
_data['authentication_type'] = 'TOKEN'
Expand Down