Fix crash and security defects in four packages#5080
Open
arsenyinfo wants to merge 2 commits intomainfrom
Open
Fix crash and security defects in four packages#5080arsenyinfo wants to merge 2 commits intomainfrom
arsenyinfo wants to merge 2 commits intomainfrom
Conversation
- libs/sync/gitignore.go: add missing return after log on open failure, preventing nil pointer dereference on non-ErrExist errors - bundle/direct/dresources/util.go: replace bare type assertion with errors.As to prevent panic on wrapped/foreign error types - cmd/labs/unpack/zipball.go: guard against empty zip panic, zip slip path traversal, and untrusted archive mode bits - experimental/aitools/cmd/discover_schema.go: validate and quote SQL identifiers to prevent injection via table name argument
arsenyinfo
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
arsenyinfo
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
simonfaltum
approved these changes
Apr 24, 2026
arsenyinfo
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
arsenyinfo
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
returnafter debug log on non-ErrExistopen failure — prevents nil*os.Filedereference (crash)err.(*retries.Err)witherrors.As— prevents panic on wrapped/foreign error types during reconciliationzipReader.File[0]on empty archive), zip slip path traversal (uncheckedfilepath.Join), and untrusted archive mode bits (zf.Mode()honored as-is including setuid/world-writable)^[A-Za-z_][A-Za-z0-9_]*$and backtick-quote identifiers — prevents SQL injection via user/agent-supplied table namesTest plan
databricks labs installstill works with valid GitHub zipballsdiscover-schemarejects malformed table names likea.b.c; DROP TABLE x