Update the lakeflow-pipelines template according to the latest Lakeflow conventions#3558
Merged
Conversation
…he lakeflow-pipelines template
lennartkats-db
requested review from
andrewnester,
anton-107,
denik,
pietern and
shreyas-goenka
as code owners
lennartkats-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
lennartkats-db
changed the title
lennartkats-db
commented
Sep 8, 2025
Collaborator
10 failing tests:
|
lennartkats-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
fjakobs
reviewed
Sep 8, 2025
pietern
reviewed
Sep 8, 2025
Contributor
pietern
left a comment
pietern
left a comment
There was a problem hiding this comment.
I can't test this end-to-end yet because of the missing pyproject.toml.
lennartkats-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
Though this is unfortunately inconsistent with the one from Black
lennartkats-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
lennartkats-db
requested review from
jefferycheng1 and
kanterov
as code owners
lennartkats-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
lennartkats-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
lennartkats-db
changed the title
lennartkats-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
fjakobs
approved these changes
Sep 22, 2025
Contributor
fjakobs
left a comment
fjakobs
left a comment
There was a problem hiding this comment.
I'm OK with the proposed changes but let's make sure to address @andersrexdb 's comment.
lennartkats-db
commented
Sep 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a new version of the
default-pythontemplate. To enable the first integration and evaluation of this template, this first pull request replaces the internallakeflow-pipelinestemplate. Replacingdefault-pythonwill be the next milestone.Changes
default-pythonto follow the Lakeflow conventions (per-pipeline sources go intoresources/; shared sources go into (lib/)lakeflow-pipelinestemplate (this required disabling some of the template questions and components)Why
Lakeflow comes with new conventions that emphasize modularity. This PR represents an initial milestone towards updating the DABs
default-pythontemplate.default-sqlwill follow in a later milestone.Tests
Existing tests were updated.