Conversation
Contributor
Author
|
Discussion with @shreyas-goenka: How to solve directory handling:
|
Contributor
Author
|
Recreated as #424. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change means we no longer do an
rm -rfof a path if we encounter an error to put a file at that location. For this reason the integration test calledTestAccIncrementalFileOverwritesFolderfails.We can fix by tracking the directories we should create and remove as separate action in the
diffstruct and perform directory creation prior to putting files and directory removal after deleting files.