login command ignores DATABRICKS_CONFIG_FILE env var and fails in absence of ~/.databrickscfg

[BenPhegan]

As part of this change #629 an explicit call to databrickscfg.DefaultPath is used rather than checking for the env var DATABRICKS_CONFIG_FILE as per

cli/cmd/auth/profiles.go

Line 20 in 6b615cc

configFile := os.Getenv("DATABRICKS_CONFIG_FILE")

This causes a hard error that prevents any further execution if there is NOT a file called ~/.databrickscfg, regardless of the DATABRICKS_CONFIG_FILE setting.

This is also explicitly used here:

cli/libs/databrickscfg/profiles.go

Line 109 in 6b615cc

_, profiles, err := LoadProfiles(DefaultPath, MatchAllProfiles)

Is there a better way to guard the use of this config default so that DATABRICKS_CONFIG_FILE is used if set regardless of which code path is run?

[mgyucht]

Thanks for raising this, my mistake. I believe I've cleaned this up in the linked PR sufficiently to prevent this class of issue from recurring.