Fix nodejs warnings#106
Merged
Merged
Conversation
Task subprocess stderr is surfaced to processing admins in run logs, where Node warnings (typeless package.json, experimental features, etc.) are never actionable. Replace the targeted --disable-warning flag with --no-warnings. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
data-fair now indexes REST writes synchronously and no longer emits a `finalize-end` journal event for them (only a compat shim on dataset creation). The hello-world fixture plugin waited for that event after writing a line, so branch-plugin e2e runs hung until timeout. Drop the wait (and the now-unused `ws` binding) and repack the tarball — the data is queryable as soon as the PUT returns. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
simple-directory now shows superadmin accounts a "Mode administration" interstitial at login, asking whether to enable admin mode for the session. The login fixture didn't handle it, so the post-login redirect never fired and every superadmin e2e login timed out. e2e specs never request admin mode (goToWithAuth takes no adminMode flag), so choose a normal session to let the redirect proceed. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace
--disable-warning=ExperimentalWarningwith--no-warningswhen spawning task subprocesses in the worker.Why: task subprocess stderr is surfaced to processing admins in run logs, where Node warnings (typeless package.json, experimental features, deprecations) are never actionable and only add noise.
Also includes test-suite repairs needed to keep e2e green, and a housekeeping bump of the local
pr-readyskill:finalize-endjournal event (tarball repacked)Heads-up:
--no-warningssuppresses all warnings, not just experimental ones — a realDeprecationWarningfrom task/plugin code will no longer appear in run logs (relevant on the next Node major upgrade).