Use raw string for docstrings containing escape sequences#455
Use raw string for docstrings containing escape sequences#455kgryte merged 1 commit intodata-apis:mainfrom
Conversation
honno
left a comment
There was a problem hiding this comment.
Yep LGTM, thanks!
Note I won't be able to update array-api-tests yet to use this immediately, as this repos changed a fair bit in the last ~month and so I need to update a few things to support it again. Probably low-priority for now 😕
Yep. Just hacking |
|
We'll backport #430 to v1 so it's still needed, but I agree if array-api is pinned it's not urgent. |
kgryte
left a comment
There was a problem hiding this comment.
LGTM. Thanks, @kmaehashi!
|
I'm running into this issue when attempting to test against |
|
Opened an issue in #631 |
Hello, my first pull-request here. 😃
When running array-api-tests against CuPy, I experienced the following error:
This was because there are unescaped uses of
\in several docstrings of array-api code, and CuPy runs tests witherror::DeprecationWarningwarning filter which strictly checks the invalid escape sequences.This PR fixes the issue by using raw string for such docstrings, in the same way as done in
cholesky:array-api/spec/API_specification/array_api/linalg.py
Lines 4 to 5 in 6a35bc1
I confirmed there are no invalid escape sequences anymore:
Thanks.