PR: Transform sorting functions from md to rst file#333
PR: Transform sorting functions from md to rst file#333kgryte merged 10 commits intodata-apis:mainfrom
Conversation
rgommers
left a comment
There was a problem hiding this comment.
Looks like a nice start, thanks @steff456!
Just a note here that we had a discussion about type annotations and whether they should be reflected in the function signatures or not (this is controlled by autodoc_typehints, see https://www.sphinx-doc.org/en/master/usage/extensions/autodoc.html). We thought it's good to start with the doing both - our type annotations are very clean, so it hopefully will look good in signatures.
Do you mean the extra space after the |
|
@asmeurer I think he meant the entirety of |
|
Based on the screenshot and looking through the changes, looks good to me. |
|
I think we can go ahead and merge this, and, if there are any further changes, we can address in follow-up PRs. Thanks, @steff456! |



This PR rewrites the sorting functions markdown file in a rst file.
Ref: #283