Skip to content

feat: Remove Spark prices operation #474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pankcuf merged 1 commit into from
Nov 23, 2022
Merged

feat: Remove Spark prices operation #474

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 3 additions & 10 deletions DashSync/shared/Models/Managers/Service Managers/Price/DSPriceOperationProvider.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@
#import "DSFetchDashRetailPricesOperation.h"
#import "DSFetchFirstFallbackPricesOperation.h"
#import "DSFetchSecondFallbackPricesOperation.h"
#import "DSFetchSparkPricesOperation.h"
#import "DSNoSucceededDependenciesCondition.h"

NS_ASSUME_NONNULL_BEGIN
Expand All @@ -38,22 +37,16 @@ + (DSOperation *)fetchPrices:(void (^)(NSArray<DSCurrencyPriceObject *> *_Nullab

DSOperation *operation1 = [[DSFetchDashRetailPricesOperation alloc] initOperationWithCompletion:mainThreadCompletion];

DSOperation *operation2 = [[DSFetchSparkPricesOperation alloc] initOperationWithCompletion:mainThreadCompletion];
DSOperation *operation2 = [[DSFetchFirstFallbackPricesOperation alloc] initOperationWithCompletion:mainThreadCompletion];
[operation2 addCondition:condition];
[operation2 addDependency:operation1];

DSOperation *operation3 = [[DSFetchFirstFallbackPricesOperation alloc] initOperationWithCompletion:mainThreadCompletion];
DSOperation *operation3 = [[DSFetchSecondFallbackPricesOperation alloc] initOperationWithCompletion:mainThreadCompletion];
[operation3 addCondition:condition];
[operation3 addDependency:operation1];
[operation3 addDependency:operation2];

DSOperation *operation4 = [[DSFetchSecondFallbackPricesOperation alloc] initOperationWithCompletion:mainThreadCompletion];
[operation4 addCondition:condition];
[operation4 addDependency:operation1];
[operation4 addDependency:operation2];
[operation4 addDependency:operation3];

DSGroupOperation *aggregateOperation = [DSGroupOperation operationWithOperations:@[operation1, operation2, operation3, operation4]];
DSGroupOperation *aggregateOperation = [DSGroupOperation operationWithOperations:@[operation1, operation2, operation3]];

return aggregateOperation;
}
Expand Down
27 changes: 0 additions & 27 deletions ...ared/Models/Managers/Service Managers/Price/FetchOperations/DSFetchSparkPricesOperation.h
View file
Open in desktop

This file was deleted.

69 changes: 0 additions & 69 deletions ...ared/Models/Managers/Service Managers/Price/FetchOperations/DSFetchSparkPricesOperation.m
View file
Open in desktop

This file was deleted.