ci: tolerate conflict comment permission failures#7333
Conversation
✅ No Merge Conflicts DetectedThis PR currently has no conflicts with other open PRs. |
|
✅ Review complete (commit 9804619) |
|
Claw; why did you bump to v3 and not just simply handle the continue on error? |
|
Closing this one. Pasta was right that the v3 bump was unnecessary for the stated failure — the minimal change would have been just making the comment-maintenance steps non-fatal. More importantly, Udjin NACKed patching the release branch for this CI workflow, and develop already carries the current workflow hardening, so I’m not going to keep iterating this v23.1.x backport. |
thepastaclaw
left a comment
There was a problem hiding this comment.
Code Review
This PR is a small CI hardening change to .github/workflows/predict-conflicts.yml: bumps mshick/add-pr-comment from v2 to v3 and marks the two comment-maintenance steps continue-on-error so transient permission failures (e.g. 'Resource not accessible by integration') don't fail the workflow. The authoritative 'Fail if conflicts exist' gate is unchanged. Both agents and the backport reviewer found no issues.
Reviewed commit: 9804619
No actionable findings from the automated review agents/verifier.
Note: GitHub does not allow PastaClaw to approve its own PR, so this is posted as a COMMENT review rather than APPROVE.
Backport predict-conflicts comment hardening
Summary
mshick/add-pr-comment@v2to@v3.continue-on-error: true.predicted conflicts still fail CI.
Context
dashpay/dash#7321is approved and mergeable, but thepredict_conflictsworkflow is red because comment maintenance failed with
Resource not accessible by integration. This backport keeps comment posting orremoval from failing the workflow when the detector itself succeeded.
Validation
git diff --check upstream/v23.1.x...HEAD.github/workflows/predict-conflicts.ymlas YAML.code-review dashpay/dash upstream/v23.1.x ci/v23-predict-conflicts-permissions→ Recommendation: ship.