Skip to content

refactor: delete extra ctors from managers, restore memory-only db for EvoDb and LLMQContext#6923

Merged
PastaPastaPasta merged 11 commits into
dashpay:developfrom
kwvg:misc_fixes
Nov 4, 2025
Merged

refactor: delete extra ctors from managers, restore memory-only db for EvoDb and LLMQContext#6923
PastaPastaPasta merged 11 commits into
dashpay:developfrom
kwvg:misc_fixes

Conversation

@kwvg
Copy link
Copy Markdown
Collaborator

@kwvg kwvg commented Oct 26, 2025

Additional Information

  • Dependency for backport: merge bitcoin#24595 (move g_versionbitscache global to ChainstateManager) #6933

  • There is a mild performance improvement when restoring memory-only databases in unit tests

    Build arguments:

    CC=clang CXX=clang++ ./configure --prefix=$(pwd)/depends/arm64-apple-darwin25 --enable-werror --enable-debug --enable-crash-hooks --enable-stacktraces --enable-zmq --enable-suppress-external-warnings --disable-ccache --disable-hardening

    develop (b82450a):

    $ ttime ./src/test/test_dash
    Running 676 test cases...
    
    *** No errors detected
    
    real:    100.50s
    user:    61.92s
    system:  12.90s
    memory:  399920KB
    

    This PR (969e2c45932437e9d5da21dc833cc33ea103d295):

    $ ttime ./src/test/test_dash # PR
    Running 676 test cases...
    
    *** No errors detected
    
    real:    75.06s
    user:    58.18s
    system:  10.03s
    memory:  394896KB
    

Breaking Changes

None expected.

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas (note: N/A)
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation (note: N/A)
  • I have assigned this pull request to a milestone (for repository code-owners and collaborators only)

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants