docs: Fix broken links from translation instructions and a typo#6739
Conversation
WalkthroughThe changes update documentation files to reflect new and current URLs for the Transifex translation platform and the official forum. In both the README.md and doc/translation_process.md files, outdated Transifex project and signup links are replaced with the latest URLs. Additionally, references to Transifex client setup documentation and download pages are updated, and the forum link is modified to a new format. No changes are made to procedures, instructions, or commands—only the web addresses and some link formatting are revised. No alterations are made to any exported or public entities. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
doc/translation_process.md (1)
43-46: Minor duplication of the project link.Lines 11 and 45 now point to the same Transifex project. Consider removing one reference or merging the two sentences to avoid redundancy.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📥 Commits
Reviewing files that changed from the base of the PR and between 1083228 and a16cfde1667664166e418547d257a399cf84e0e0.
📒 Files selected for processing (2)
README.md(1 hunks)doc/translation_process.md(4 hunks)
🧰 Additional context used
🧠 Learnings (1)
📓 Common learnings
Learnt from: kwvg
PR: dashpay/dash#6543
File: src/wallet/receive.cpp:240-251
Timestamp: 2025-02-06T14:34:30.466Z
Learning: Pull request #6543 is focused on move-only changes and refactoring, specifically backporting from Bitcoin. Behavior changes should be proposed in separate PRs.
Learnt from: knst
PR: dashpay/dash#6533
File: test/functional/feature_llmq_singlenode.py:98-106
Timestamp: 2025-01-22T08:33:31.405Z
Learning: When reviewing PRs, ensure that suggestions are directly related to the PR's primary objectives rather than general code improvements that could be addressed separately.
⏰ Context from checks skipped due to timeout of 90000ms (6)
- GitHub Check: x86_64-pc-linux-gnu_multiprocess / Build depends
- GitHub Check: x86_64-w64-mingw32 / Build depends
- GitHub Check: x86_64-apple-darwin / Build depends
- GitHub Check: x86_64-pc-linux-gnu_nowallet / Build depends
- GitHub Check: x86_64-pc-linux-gnu / Build depends
- GitHub Check: arm-linux-gnueabihf / Build depends
🔇 Additional comments (5)
doc/translation_process.md (4)
11-11: Updated Transifex project URL looks correct.The new
explore.transifex.compath resolves the earlier 404 and keeps the paragraph intact.
48-48: CLI docs link update LGTM.
developers.transifex.com/docs/cliis the canonical location for the new CLI documentation.
68-68: Verify section-anchor still exists.The fragment
#download-from-github-releases-linuxmacwindowsmay have changed in the new docs site. Please double-check that the URL still lands on the intended heading; if not, drop the anchor and let the page load at the top.
108-108: Forum link updated—good catch.The new forum URL loads correctly and avoids redirect chains.
README.md (1)
92-94: Transifex link fixed—no further action needed.The updated URL eliminates the old
/projects/p/pattern and resolves properly.
UdjinM6
changed the title
UdjinM6
left a comment
UdjinM6
left a comment
There was a problem hiding this comment.
LGTM but
Merging is blocked
Commits must have verified signatures.
|
Signed now! |
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
doc/translation_process.md (2)
45-45: Style nit – use a consistent link format
Earlier in the paragraph you use the Markdown[text](url)style, while here you switch to angle-bracket autolinks. Consider keeping one style for consistency:-You can find the Dash translation project at <https://explore.transifex.com/dash/dash/>. +You can find the Dash translation project at [https://explore.transifex.com/dash/dash/](https://explore.transifex.com/dash/dash/).
108-108: Minor grammar fix
Add the missing article “the” for smoother reading:-Check official forum at <https://www.dash.org/forum/forums/dash-worldwide-collaboration.88/>. +Check the official forum at <https://www.dash.org/forum/forums/dash-worldwide-collaboration.88/>.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📥 Commits
Reviewing files that changed from the base of the PR and between a16cfde1667664166e418547d257a399cf84e0e0 and b58d77a.
📒 Files selected for processing (2)
README.md(1 hunks)doc/translation_process.md(4 hunks)
✅ Files skipped from review due to trivial changes (1)
- README.md
🧰 Additional context used
🧠 Learnings (1)
📓 Common learnings
Learnt from: kwvg
PR: dashpay/dash#6543
File: src/wallet/receive.cpp:240-251
Timestamp: 2025-02-06T14:34:30.466Z
Learning: Pull request #6543 is focused on move-only changes and refactoring, specifically backporting from Bitcoin. Behavior changes should be proposed in separate PRs.
🪛 markdownlint-cli2 (0.17.2)
doc/translation_process.md
47-47: Heading style
Expected: setext; Actual: atx
(MD003, heading-style)
🪛 LanguageTool
doc/translation_process.md
[uncategorized] ~108-~108: You might be missing the article “the” here.
Context: ... Questions and general assistance Check official forum at <https://www.dash.org/forum/fo...
(AI_EN_LECTOR_MISSING_DETERMINER_THE)
⏰ Context from checks skipped due to timeout of 90000ms (4)
- GitHub Check: arm-linux-build / Build source
- GitHub Check: x86_64-pc-linux-gnu_multiprocess / Build depends
- GitHub Check: x86_64-apple-darwin / Build depends
- GitHub Check: x86_64-pc-linux-gnu / Build depends
🔇 Additional comments (4)
doc/translation_process.md (4)
11-11: Updated Transifex project URL looks good
The new link resolves correctly and uses the current Transifex project path.
43-43: Signup link verified
https://app.transifex.com/signup/is the expected modern signup URL. No issues.
48-48: CLI docs link validated
https://developers.transifex.com/docs/cliis the canonical page for the current CLI; hyperlink works.
68-68: Anchor fragment may have changed – please verify
The long hash#download-from-github-releases-linuxmacwindowsoccasionally changes when Transifex reshuffles headings. Double-check the URL still lands on the Download from GitHub Releases section; if not, drop the fragment:-Please see <https://developers.transifex.com/docs/cli#download-from-github-releases-linuxmacwindows> for details on installation. +Please see <https://developers.transifex.com/docs/cli> for details on installation.
…ons and a typo b58d77a Fix broken links from translation instructions and a typo (Jorge Maldonado Ventura) Pull request description: It fixes broken links from the translation instructions and a typo. ## Issue being fixed or feature implemented - Contributors won't be shown a broken link ## What was done? Just replace the links and fix the typo. ## How Has This Been Tested? I checked that the new links work fine. ## Breaking Changes None ## Checklist: _Go over all the following points, and put an `x` in all the boxes that apply._ - [x] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have added or updated relevant unit/integration/functional/e2e tests - [ ] I have made corresponding changes to the documentation - [ ] I have assigned this pull request to a milestone _(for repository code-owners and collaborators only)_ ACKs for top commit: UdjinM6: utACK b58d77a Tree-SHA512: e8609605a326dd3f780eea0213dec949d4b163469c6171ce8336fcdbcc282932491b7cc36f40d2aa198c6ba25ace6ddba1fb2fd5fca0de396831d29f96eac6b5
9ec8e66 docs: add v22.1.3 release notes and archive v22.1.2 (pasta) 95c2a0e chore: bump version to v22.1.3 (pasta) 3345046 chore: update chainparams for v22.1.3 release (pasta) 1db850a Merge #6632: perf: versionbits avoid calculation which is not used (pasta) 4173e3c Merge #6739: docs: Fix broken links from translation instructions and a typo (pasta) 9eda785 Merge #6740: feat: improve logging of non-existing destinations for masternode payment (pasta) 47b6826 Merge #6744: fix: remove useless but alarming log record about spent information (pasta) Pull request description: ## Issue being fixed or feature implemented Backports for a new version, v22.1.3 ## What was done? See release notes ## How Has This Been Tested? ## Breaking Changes None ## Checklist: - [x] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have added or updated relevant unit/integration/functional/e2e tests - [ ] I have made corresponding changes to the documentation - [x] I have assigned this pull request to a milestone _(for repository code-owners and collaborators only)_ ACKs for top commit: UdjinM6: utACK 9ec8e66 kwvg: utACK 9ec8e66 Tree-SHA512: 9e94b472c32f87c46d60fe53bcec59cb2ec1823e56cfbc2fe4a07d476e1c576c0d7f0c54115aeca902767651591556d68c8e81b81ac9bd12bc5291fa17f5a768
9ec8e66 docs: add v22.1.3 release notes and archive v22.1.2 (pasta) 95c2a0e chore: bump version to v22.1.3 (pasta) 3345046 chore: update chainparams for v22.1.3 release (pasta) 1db850a Merge #6632: perf: versionbits avoid calculation which is not used (pasta) 4173e3c Merge #6739: docs: Fix broken links from translation instructions and a typo (pasta) 9eda785 Merge #6740: feat: improve logging of non-existing destinations for masternode payment (pasta) 47b6826 Merge #6744: fix: remove useless but alarming log record about spent information (pasta) Pull request description: ## Issue being fixed or feature implemented ## What was done? ## How Has This Been Tested? ## Breaking Changes n/a ## Checklist: - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have added or updated relevant unit/integration/functional/e2e tests - [ ] I have made corresponding changes to the documentation - [ ] I have assigned this pull request to a milestone _(for repository code-owners and collaborators only)_ ACKs for top commit: PastaPastaPasta: utACK 2527ca5 kwvg: utACK 2527ca5 Tree-SHA512: 3ecf4f26a816db6be797208ce5d519b8c3571a4aae832d8a1dcf41add4cc48d102459302e1777786b19f577c0a3222d77ce490e2301e73963d6021e2cdc2ad86
4 participants
It fixes broken links from the translation instructions and a typo.
Issue being fixed or feature implemented
What was done?
Just replace the links and fix the typo.
How Has This Been Tested?
I checked that the new links work fine.
Breaking Changes
None
Checklist:
Go over all the following points, and put an
xin all the boxes that apply.