Skip to content

style: rename variable to avoid shadowing#5020

Merged
UdjinM6 merged 1 commit into
dashpay:developfrom
PastaPastaPasta:style/rename-shadow
Sep 23, 2022
Merged

style: rename variable to avoid shadowing#5020
UdjinM6 merged 1 commit into
dashpay:developfrom
PastaPastaPasta:style/rename-shadow

Conversation

@PastaPastaPasta
Copy link
Copy Markdown
Member

Issue being fixed or feature implemented

#4993 introduced a shadowing, this resolves the shadow

What was done?

Renamed single variable

How Has This Been Tested?

Compiles, simple renaming in constrained scope

Breaking Changes

None

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@PastaPastaPasta PastaPastaPasta added this to the 18.1 milestone Sep 20, 2022
@knst
Copy link
Copy Markdown
Collaborator

knst commented Sep 20, 2022

LGTM, utACK

Copy link
Copy Markdown

@UdjinM6 UdjinM6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@UdjinM6 UdjinM6 merged commit dd2ae58 into dashpay:develop Sep 23, 2022
@PastaPastaPasta PastaPastaPasta deleted the style/rename-shadow branch September 24, 2022 10:59
@UdjinM6 UdjinM6 modified the milestones: 18.1, 18.2 Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants