Add function to validate DSTX message#4713
Merged
PastaPastaPasta merged 4 commits intoApr 2, 2022
Merged
Conversation
|
This pull request has conflicts, please rebase. |
Member
|
still needs rebase |
Author
|
I am not sure what went wrong. I created this branch from develop (and felt I had done a pull before that). I can create a new PR |
Member
|
You'll need to fetch latest develop. something like Then |
rkarthik2k21
force-pushed
the
validate_dstx_issue_4078
branch
from
4e7b296 to
af377ea
Compare
UdjinM6
requested changes
Mar 25, 2022
UdjinM6
requested changes
Mar 29, 2022
UdjinM6
reviewed
Mar 30, 2022
PastaPastaPasta
approved these changes
Apr 2, 2022
Member
PastaPastaPasta
left a comment
PastaPastaPasta
left a comment
There was a problem hiding this comment.
utACK for squash merge
gades
pushed a commit
to cosanta/cosanta-core
that referenced
this pull request
Nov 29, 2023
* Add function to validate DSTX message * Addressed review comment: Remove text left due to merge * Apply suggestions from code review * Update src/net_processing.cpp Co-authored-by: UdjinM6 <UdjinM6@users.noreply.github.com>
gades
pushed a commit
to piratecash/pirate
that referenced
this pull request
Dec 9, 2023
* Add function to validate DSTX message * Addressed review comment: Remove text left due to merge * Apply suggestions from code review * Update src/net_processing.cpp Co-authored-by: UdjinM6 <UdjinM6@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is part of addressing issue 4078 - Test DSTX validation during propogation #4078 (#4078)
A function ValidateDSTX() has been added that essentially captures the existing code to validate a DSTX message. A unit test can be created to call this method in order for testing DSTX validation