Skip to content

Backports 0.19 pr11#4632

Merged
PastaPastaPasta merged 7 commits into
dashpay:developfrom
Munkybooty:backports-0.19-pr11
Dec 29, 2021
Merged

Backports 0.19 pr11#4632
PastaPastaPasta merged 7 commits into
dashpay:developfrom
Munkybooty:backports-0.19-pr11

Conversation

@Munkybooty
Copy link
Copy Markdown

@Munkybooty Munkybooty commented Dec 21, 2021

I'm unable to build so this may be my worst pr yet. apologies in advance for that if there is a lot of trivial errors that have been missed.

UdjinM6
UdjinM6 requested changes Dec 22, 2021
View reviewed changes
Comment thread src/rpc/rawtransaction.cpp Outdated
Comment thread src/rpc/rawtransaction.cpp Outdated
Comment thread src/test/blockfilter_index_tests.cpp Outdated
Comment thread src/script/standard.h Outdated
Comment thread src/interfaces/chain.cpp Outdated
Comment thread Makefile.am Outdated
UdjinM6
UdjinM6 requested changes Dec 23, 2021
View reviewed changes
Comment thread test/functional/feature_shutdown.py Outdated
UdjinM6
UdjinM6 requested changes Dec 25, 2021
View reviewed changes
Comment thread src/rpc/server.cpp Outdated
Comment thread doc/release-notes-15637.md Outdated
MarcoFalke and others added 5 commits December 26, 2021 22:23
@Munkybooty
Merge bitcoin#15616: rpc: Clarify decodescript RPCResult doc
b3f0ec5 
fa926ec rpc: Mention all output types in decodescript doc (MarcoFalke)
fa3caa1 rpc: decodescript use IsValidNumArgs over hardcoded check (MarcoFalke)
faad33f rpc: Clarify decodescript RPCResult doc (MarcoFalke)

Pull request description:

  * Remove `"hex"` from the decodescript RPCResult doc
  * Add `"segwit`" to the doc

  Follow up to a6099ef and 4f933b3

ACKs for commit fa926e:
  ryanofsky:
    utACK fa926ec. Only change since last review is listing possible output types in the help string using a new `GetAllOutputTypes` function

Tree-SHA512: e6ecc563d04769942567118d50188467bf64ceb276ba6268928d469e8f06621f2ca1ae1e555d3daa6ec22a615ee259bb31c4141c19818d0f53fb6c529b18381b
@meshcollider @Munkybooty
Merge bitcoin#15557: Enhance bumpfee to include inputs when targeti…
7975686 
…ng a feerate

184f878 wallet_bumpfee.py: add test for change key preservation (Gregory Sanders)
d08becf add functional tests for feerate bumpfee with adding inputs (Gregory Sanders)
0ea47ba generalize bumpfee to add inputs when needed (Gregory Sanders)

Pull request description:

  When targeting a feerate using `bumpfee`, call a new function that directly uses `CWallet::CreateTransaction` and coin control to get the desired result. This allows us to get a superset of previous behavior, with an arbitrary RBF bump of a transaction provided it passes the preconditional checks and spare confirmed utxos are available.

  Note(s):
  0) The coin selection will use knapsack solver for the residual selection.
  1) This functionality, just like knapsack coin selection in general, will hoover up negative-value inputs when given the chance.
  2) Newly added inputs must be confirmed due to current Core policy. See error: `replacement-adds-unconfirmed`
  3) Supporting this with `totalFee` is difficult since the "minimum total fee" option in `CreateTransaction` logic was (rightly)taken out in bitcoin#10390 .

ACKs for commit 184f87:
  jnewbery:
    utACK 184f878

Tree-SHA512: fb6542bdfb2c6010e328ec475cf9dcbff4eb2b1a1b27f78010214534908987a5635797196fa05edddffcbcf2987335872dc644a99261886d5cbb34a8f262ad3e
@Munkybooty
Merge bitcoin#15670: refactor: combine Chain::findFirstBlockWithTime/…
f17497a 
…findFirstBlockWithTimeAndHeight

765c0b3 refactor: combine Chain::findFirstBlockWithTime/findFirstBlockWithTimeAndHeight (Antoine Riard)

Pull request description:

  As suggested in bitcoin#14711, pass height to CChain::FindEarliestAtLeast to
  simplify Chain interface by combining findFirstBlockWithTime and
  findFirstBlockWithTimeAndHeight into one

ACKs for commit 765c0b:
  jnewbery:
    utACK 765c0b3. Nice work @ariard!
  ryanofsky:
    utACK 765c0b3. Looks good, thanks for implementing the suggestion!

Tree-SHA512: 63f98252a93da95f08c0b6325ea98f717aa9ae4036d17eaa6edbec68e5ddd65672d66a6af267b80c36311fffa9b415a47308e95ea7718b300b685e23d4e9e6ec
@Munkybooty
Merge bitcoin#12051: add missing debian contrib file to tarball
baf262b 
5d7ce74 add missing debian contrib files to tarball (Peter Wagner)

Pull request description:

  the current release is missing the debian contrib folder, add it

ACKs for commit 5d7ce7:

Tree-SHA512: 9d38c9ec0cc13171582c0bde57a2f69b22026a91f353e20da556cb63a4cfbba68b2465c9c62eaa98df50a65d971cc4411ffee519824b34068772ae8ddedb7d4c
@Munkybooty
Merge bitcoin#15877: doc: Fix -dustrelayfee= argument docs grammar
744ebbe 
64491cb doc: Fix -dustrelayfee= argument docs grammar (keepkeyjon)

Pull request description:

ACKs for commit 64491c:
  fanquake:
    utACK 64491cb

Tree-SHA512: 562180e5bb065c71cda89555afd1cd5a54a98b058ab9006af3a6437fbbde46c7f3930b3fe98900bbb18f329057e00da81bc8290bdf6160d7eccc97d255b30e4b
@laanwj @Munkybooty
Merge bitcoin#14982: rpc: Add getrpcinfo command
e54d4af 
a0ac154 doc: Add getrpcinfo release notes (João Barbosa)
251a91c qa: Add tests for getrpcinfo (João Barbosa)
d0730f5 rpc: Add getrpcinfo command (João Barbosa)
068a8fc rpc: Track active commands (João Barbosa)
bf43832 rpc: Remove unused PreCommand signal (João Barbosa)

Pull request description:

  The new `getrpcinfo` command exposes details of the RPC interface. The details can be configuration properties or runtime values/stats.

  This can be particular useful to coordinate concurrent functional tests (see bitcoin#14958 from where this was extracted).

Tree-SHA512: 7292cb6087f4c429973d991aa2b53ffa1327d5a213df7d6ba5fc69b01b2e1a411f6d1609fed9234896293317dab05f65064da48b8f2b4a998eba532591d31882
@laanwj @Munkybooty
Merge bitcoin#14958: qa: Remove race between connecting and shutdown …
8de8cf3 
…on separate connections

4412a59 qa: Remove race between connecting and shutdown on separate connections (João Barbosa)

Pull request description:

  Fixes the error bitcoin#14670 (comment) reported by @ken2812221.

  There is a race between RPC stop and another concurrent call in the test framework. The connection must be established and the command `waitfornewblock` running before calling `stop`.

  See also bitcoin#14670 (comment).

Tree-SHA512: 77feb8628d3b9c025ec0cf83565d4d6680cad4fb182fc93a65df8b573f3e799ba4c44e06d9001dd8a375ca0b1ee17f10e66c3902b6256d0ae2acbc64539185d7
UdjinM6
UdjinM6 approved these changes Dec 28, 2021
View reviewed changes
Copy link
Copy Markdown

@UdjinM6 UdjinM6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@thephez thephez added the RPC Some notable changes to RPC params/behaviour/descriptions label Dec 29, 2021
PastaPastaPasta
PastaPastaPasta approved these changes Dec 29, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@PastaPastaPasta PastaPastaPasta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK for merging via merge commit

@PastaPastaPasta PastaPastaPasta added this to the 18 milestone Dec 29, 2021
@PastaPastaPasta PastaPastaPasta merged commit 19149f5 into dashpay:develop Dec 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@UdjinM6 UdjinM6 UdjinM6 approved these changes

@PastaPastaPasta PastaPastaPasta PastaPastaPasta approved these changes

Assignees

No one assigned

Labels

RPC Some notable changes to RPC params/behaviour/descriptions

Projects

None yet

Milestone

18

Development

Successfully merging this pull request may close these issues.

6 participants

@Munkybooty @UdjinM6 @PastaPastaPasta @thephez @meshcollider @laanwj