Skip to content

llmq: Implement Intra-Quorum Relay connections for qrecsig-s#4020

Merged
PastaPastaPasta merged 5 commits into
dashpay:developfrom
UdjinM6:mn_iqr_c
Mar 15, 2021
Merged

llmq: Implement Intra-Quorum Relay connections for qrecsig-s#4020
PastaPastaPasta merged 5 commits into
dashpay:developfrom
UdjinM6:mn_iqr_c

Conversation

@UdjinM6
Copy link
Copy Markdown

@UdjinM6 UdjinM6 commented Feb 28, 2021

Avoid relaying recsigs to non-masternodes.

Avoid relaying recsigs to non-masternodes.
@UdjinM6 UdjinM6 added this to the 17 milestone Feb 28, 2021
@UdjinM6 UdjinM6 marked this pull request as ready for review February 28, 2021 14:04
Copy link
Copy Markdown

@xdustinface xdustinface left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall but see suggestions-4020 for some tweaks to the changes in tests.

Copy link
Copy Markdown

@xdustinface xdustinface left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@UdjinM6 UdjinM6 requested a review from PastaPastaPasta March 9, 2021 01:31
@PastaPastaPasta
Copy link
Copy Markdown
Member

Can a node opt in to receiving recovered sigs?

@UdjinM6
Copy link
Copy Markdown
Author

UdjinM6 commented Mar 12, 2021

Copy link
Copy Markdown
Member

@PastaPastaPasta PastaPastaPasta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@PastaPastaPasta PastaPastaPasta merged commit 95e8492 into dashpay:develop Mar 15, 2021
@UdjinM6 UdjinM6 deleted the mn_iqr_c branch July 1, 2021 21:58
gades pushed a commit to cosanta/cosanta-core that referenced this pull request Mar 13, 2022
…#4020)

* llmq: Implement Intra-Quorum Relay connections for qrecsig-s

Avoid relaying recsigs to non-masternodes.

* test: Simplify loop

* test: Assert connections are equal to llmq_size instead of static number

* test: Drop redundant brackets

* test: Fix typo

Co-authored-by: xdustinface <xdustinfacex@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants