Skip to content

tests: Fix PrivateSend and wallet unit tests after 3680#3724

Merged
UdjinM6 merged 1 commit into
dashpay:developfrom
UdjinM6:fixtestsafter3680
Sep 23, 2020
Merged

tests: Fix PrivateSend and wallet unit tests after 3680#3724
UdjinM6 merged 1 commit into
dashpay:developfrom
UdjinM6:fixtestsafter3680

Conversation

@UdjinM6
Copy link
Copy Markdown

@UdjinM6 UdjinM6 commented Sep 21, 2020

Tests in #3667 and #3677 were implemented before/in parallel to #3680, so they fail to compile now. This should fix it.

@UdjinM6 UdjinM6 added this to the 17 milestone Sep 21, 2020
Copy link
Copy Markdown

@xdustinface xdustinface left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

Copy link
Copy Markdown
Collaborator

@thephez thephez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK. Builds successfully now. 👍

@UdjinM6 UdjinM6 mentioned this pull request Sep 22, 2020
Copy link
Copy Markdown
Member

@PastaPastaPasta PastaPastaPasta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

Lets merge this first

@UdjinM6 UdjinM6 merged commit 9139fb1 into dashpay:develop Sep 23, 2020
@UdjinM6 UdjinM6 deleted the fixtestsafter3680 branch November 26, 2020 13:26
gades pushed a commit to cosanta/cosanta-core that referenced this pull request Mar 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants