Skip to content

Fix bls and bls_dkg bench#2955

Merged
UdjinM6 merged 1 commit into
dashpay:developfrom
rikublock:2019_fix_bench
May 30, 2019
Merged

Fix bls and bls_dkg bench#2955
UdjinM6 merged 1 commit into
dashpay:developfrom
rikublock:2019_fix_bench

Conversation

@rikublock
Copy link
Copy Markdown

Properly start the blsWorker before running any BLS related benchmark tests. Failure to do so results in certain bench tests getting stuck. Possibly related to #2820 .

UdjinM6
UdjinM6 previously approved these changes May 29, 2019
Copy link
Copy Markdown

@UdjinM6 UdjinM6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! 👍

ACK

@UdjinM6 UdjinM6 added this to the 14.1 milestone May 29, 2019
@UdjinM6 UdjinM6 changed the base branch from master to develop May 29, 2019 16:08
@UdjinM6 UdjinM6 changed the base branch from develop to master May 29, 2019 16:09
@UdjinM6 UdjinM6 dismissed their stale review May 29, 2019 16:09

wrong branch

@UdjinM6
Copy link
Copy Markdown

UdjinM6 commented May 29, 2019

Ahh... Unfortunately we don't merge into master. Could you please rebase this on top of develop?

Properly start the blsWorker before running any BLS related benchmarks.
@rikublock rikublock changed the base branch from master to develop May 29, 2019 17:05
@rikublock
Copy link
Copy Markdown
Author

rikublock commented May 29, 2019

Made some changes. Let me know, if that works.

Copy link
Copy Markdown
Member

@PastaPastaPasta PastaPastaPasta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

Copy link
Copy Markdown

@UdjinM6 UdjinM6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

re-ACK

Copy link
Copy Markdown

@codablock codablock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@UdjinM6 UdjinM6 merged commit 26bd0d2 into dashpay:develop May 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants