DIP3 MN reward payment logic#2258
Merged
Merged
Conversation
UdjinM6
requested changes
Sep 4, 2018
UdjinM6
left a comment
UdjinM6
left a comment
There was a problem hiding this comment.
A couple of my usual complains :) otherwise looks good 👍
There was a problem hiding this comment.
map prefix + too general (mapPayments?)
There was a problem hiding this comment.
should remove the one below then (line 18)
codablock
force-pushed
the
pr_dip3_paymentlogic
branch
from
b5e2618 to
a0e45d8
Compare
Author
|
Pushed review fixes |
PastaPastaPasta
requested changes
Sep 4, 2018
Member
PastaPastaPasta
left a comment
PastaPastaPasta
left a comment
There was a problem hiding this comment.
See inline for formatting corrections
Member
There was a problem hiding this comment.
technically should be one line or brackets. ¯\(ツ)/¯ @nmarley
Member
There was a problem hiding this comment.
above - brackets or same line
There was a problem hiding this comment.
nit: could probably squash 2 ifs above into || thing
codablock
force-pushed
the
pr_dip3_paymentlogic
branch
from
a0e45d8 to
3837215
Compare
Author
|
@PastaPastaPasta applied a few of your suggestions, but left the ones out that are surrounded by the same type of code style violation. Better to create a PR with a general cleanup later. |
codablock
force-pushed
the
pr_dip3_paymentlogic
branch
from
3837215 to
96e5695
Compare
UdjinM6
previously approved these changes
Sep 5, 2018
UdjinM6
left a comment
UdjinM6
left a comment
There was a problem hiding this comment.
re-utACK
A couple of things here are not quite good for readability but let's get to it in some another cleanup PR.
|
ooops, merge conflit. sorry 🙈 |
Ensure correct locking order to fix deadlock.
1. Enforce payment to masternodes in IsBlockPayeeValid even if superblocks are triggered. This new rule only gets activated when spork15 activates. 2. Always enforce masternode payments when spork15 is activated and ignore spork8 in that case. spork8 can be removed after spork15 activation and hardening of the spork15 height into consensus params.
Needed for privatesend when choosing masternodes
codablock
force-pushed
the
pr_dip3_paymentlogic
branch
from
96e5695 to
d8247df
Compare
Author
|
Merge conflicts fixed. These were just minor ones caused by code cleanups |
thephez
added a commit
to dash-docs/dash-docs
that referenced
this pull request
Dec 18, 2018
thephez
added a commit
to dash-docs/dash-docs
that referenced
this pull request
Dec 26, 2018
* Content - RPC - Update quick reference * RPC - Update getblockchaininfo to show BIP-9 progress Related to dashpay/dash#2435 * RPC - Update gobject prepare with new params Use-IS (dashpay/dash#2452) Use specific UTXO for fee (dashpay/dash#2482) * RPC - Update mode name * RPC - Update protx default mode dashpay/dash#2513 * Content - Add spork 17 * Content - Special transactions Add info for Quorum commitment Remove messages not in 13.0 (SubTx) * P2P - Add new txlvote fields masternodeProTxHash (dashpay/dash#2484) quorumModifierHash (dashpay/dash#2505) * RPC - Update protx list Make all options follow the same parameter format (dashpay/dash#2559) * Content - version bump 0.13.0.0 bumped to 70213 (dashpay/dash#2557) * Guide - PrivateSend dstx message limit Up to 5 simultaneous dstxs per MN allowed (dashpay/dash#2552) * RPC - Update getblock Add missing versionHex field (dashpay/dash@e7d9ffa) Change to use verbosity syntax (dashpay/dash#2506 and bitcoin/bitcoin#8704) * P2P - Add qfcommit message (no hexdump example) DIP6 quorum final commitment (dashpay/dash#2477) * P2P - qfcommit typo Change description of llmqType field * P2P - Special tx payload size clarification * Guide - Update MN payment description Related to dashpay/dash#2258 * Guide - fix broken link * Guide - Update some example txs Change to hashes on the chain following the 12.3.4 reset * P2P - Add QcTx hexdump * P2P - DIP4 message updates Add SML entry Update hexdump to include new fields Add getmnlistd and mnlistdiff to cross ref * P2P - minor DIP3-related comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is extracted from #2083. It introduces the new MN reward payment logic for deterministic masternodes.
It also enforces MN reward payments when superblocks are paid out (no more lucky miners getting 100% of the reward). This happens after spork15 activation.