Split keyIDMasternode into keyIDOwner/keyIDOperator/keyIDVoting#2248
Merged
Conversation
Author
|
Also added acf8203 |
UdjinM6
requested changes
Aug 31, 2018
There was a problem hiding this comment.
keyIDMasternode? Is this intentional (for backwards compatibility) or ..?
Author
There was a problem hiding this comment.
Yepp. This RPC will become unused after spork15 activation and at the same time I assume external tools are using this
There was a problem hiding this comment.
Should probably alter rejection reason a bit so that it would be easier to debug i.e. bad-protx-payee-dest or smth like that
There was a problem hiding this comment.
The comment here is a bit confusing imo. This doesn't allow reuse of keys which control payout address for other purposes, not reuse of keys in general.
keyIDOwner is the key used for things which should stay in control of the collateral owner, like proposal voting. keyIDOperator is the key used for operational things, like signing network messages, signing trigger/watchdog objects and trigger votes. keyIDVoting is the key used for proposal voting Legacy masternodes will always have the same key for all 3 to keep compatibility. Using different keys is only allowed after spork15 activation.
codablock
force-pushed
the
pr_dip3_keysplit
branch
from
acf8203 to
7084496
Compare
Author
|
Pushed review fixes |
Author
|
@UdjinM6 Forgot to bump CMasternodeMan version string, pushed this now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is extracted from #2083. It can stand on its own and without all the other DIP3 code, it will simply default to using the same key for all 3 new keys.