[AI] Add raster mask export for object masks#20646
[AI] Add raster mask export for object masks#20646andriiryzhkov wants to merge 2 commits intodarktable-org:masterfrom
Conversation
dc0ad15 to
b7130ce
Compare
TurboGit
left a comment
There was a problem hiding this comment.
Frankly I'm not sure if it is useful or not. I certainly won't use this, but that's only me. I cannot come with a scenario where this will be handy at the moment.
If I understand correctly, this would allow to have a more precise mask than the vectorized mask (e.g. for rugged edges). |
|
Not sure, if there will be any quality benefits. Vectorisation is pretty accurate if you keep smoothing at 0. Maybe at some edge cases. But that adds dependency on an external file. So pipe willing work correctly without it. |
Ok, never mind. I thought this a mitigation for what was discussed in this posting on pixls.us |
Me too. But I saw people asking about it. And it's not a big feature, so decided to propose it. We can keep it for later if there will be more requests. |
It is exactly for that purpose. Just not sure if it will help much with fine details on edges. But idea is that it might be useful for someone. |
TurboGit
left a comment
There was a problem hiding this comment.
Ok, let's go with this. Thanks.
|
@andriiryzhkov : Seems like there is an issue with this PR. For a reason I cannot understand I cannot merge this. GitHub tells me that the branch is not properly sync. When I pull the branch directly from your repo I have 2 commits. Can you force push the branch again? TIA. |
e257ffd to
e9d82c6
Compare
Done |
Another small improvement. Not 100% sure about it, but maybe helpful for someone.
Adds the ability to export the SAM segmentation mask as an RGB PNG file, compatible with the external raster masks module. Triggered by shift+right-click during object mask creation.
How it works
Output format
rasterfileIOP moduleplugins/darkroom/segments/def_path){image_name}_mask.png, auto-incremented (_1,_2, ...) if file exists