Upgrade all to readability 0.6.0#29
Open
NotDroidUser wants to merge 22 commits into
Open
Conversation
Changed assertion method to compare HTML directly for better diffs Some tests are not working due to formatting
…ges by the ide and kotlin things (things more Kotlin less Java)
…t works as intended anyways
updated maven tag to jitpack one
|
This repo seems to be no longer maintained. Have you thought about forking it and pushing your update there? |
Author
|
That’s what I did in January, but on JitPack. There are still a few tweaks needed to make it 1:1, but it works, for a news reader. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have updated also the test cases to the latest readability.js there is yet some bugs but with some work comparing logs maybe can get them, yet at least almost all cases are <p> tags that wasn't added/removed