Skip to content

fix(pulse): resolve pai-root-relative targetFile in applyProposalEdit (memory-proposal apply fails) #1507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
anikinsasha wants to merge 1 commit into from
Closed

fix(pulse): resolve pai-root-relative targetFile in applyProposalEdit (memory-proposal apply fails) #1507

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions LifeOS/install/LIFEOS/PULSE/lib/telegram-proposals.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@

import { appendFileSync, existsSync, readFileSync, renameSync, writeFileSync } from "node:fs";
import { homedir } from "node:os";
import { join } from "node:path";
import { isAbsolute, join } from "node:path";
import {
PENDING_PROPOSALS_PATH,
inferProposalKind,
Expand Down Expand Up @@ -157,9 +157,14 @@ export function parseProposalReply(text: string): ProposalReply {
}

export function applyProposalEdit(targetFile: string, editText: string): { ok: true } | { ok: false; reason: string } {
if (!existsSync(targetFile)) return { ok: false, reason: `target file missing: ${targetFile}` };
// A proposal's targetFile is pai-root-relative (e.g. "LIFEOS/USER/CONFIG/OPERATIONAL_RULES.md").
// Resolve it against ~/.claude so it works regardless of the process CWD: the Telegram bot runs
// from LIFEOS/PULSE, so a bare relative path resolved to a nonexistent nested path and every apply
// failed with "target file missing" even though the file was present.
const resolved = isAbsolute(targetFile) ? targetFile : join(HOME, ".claude", targetFile);
if (!existsSync(resolved)) return { ok: false, reason: `target file missing: ${targetFile}` };
try {
const current = readFileSync(targetFile, "utf8");
const current = readFileSync(resolved, "utf8");
const sectionHeader = "## Memory-System Proposals";
const ts = new Date().toISOString();
const entry = `\n- ${editText} <!-- applied: ${ts} -->`;
Expand All @@ -169,9 +174,9 @@ export function applyProposalEdit(targetFile: string, editText: string): { ok: t
} else {
next = current.trimEnd() + `\n\n${sectionHeader}\n\n${entry.trim()}\n`;
}
const tmp = `${targetFile}.tmp`;
const tmp = `${resolved}.tmp`;
writeFileSync(tmp, next, "utf8");
renameSync(tmp, targetFile);
renameSync(tmp, resolved);
return { ok: true };
} catch (e) {
return { ok: false, reason: (e as Error)?.message ?? String(e) };
Expand Down