Skip to content

🐞 Installed version checking does not support version without v (eg. 0.18.12) #193

@tmablunar

Description

@tmablunar

What is the issue?

While the action itself supports defining the version with or without the full version including v, ie. 0.18.12 or v0.18.12, when it checks for an already installed version it will only work when using full version format including v because dagger version includes v.

Dagger version

Not relevant

Steps to reproduce

Define an action with version without v

dagger/dagger-for-github@v8.2.0
  with:
    version: 0.18.12

this will give the output below.

Log output

Checking dagger
Found existing dagger version: v0.18.12
Installing dagger
sh debug downloading files into /tmp/tmp.bh5HO9PyXz
sh debug http_download https://dl.dagger.io/dagger/releases/0.18.12/dagger_v0.18.12_linux_amd64.tar.gz
sh debug http_download https://dl.dagger.io/dagger/releases/0.18.12/checksums.txt
sh debug display shell completion instructions
sh info installed /home/runner/_work/_temp/bin/dagger

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions