Conversation
Owner
|
Great thanks. As I cannot test it on OSX, please let me know if you have any other problems later. |
Closed
kennethho
pushed a commit
to kennethho/node.native
that referenced
this pull request
Dec 17, 2012
It's making node.js crash when run as root. Backtrace: (gdb) bt #0 0x00007fff856e3ff9 in __findenv () d5#1 0x00007fff856e404c in getenv () d5#2 0x000000010004c850 in loop_init (loop=0x10045a792, flags=8) at ev.c:1707 d5#3 0x000000010004cb3b in ev_backend [inlined] () at /Users/tjfontaine/Development/node/deps/uv/src/unix/ev/ev.c:2090 d5#4 0x000000010004cb3b in ev_default_loop (flags=1606417108) at ev.c:2092 d5#5 0x000000010004e5c6 in uv__loop_init (loop=0x10066e330, default_loop=1) at loop.c:52 d5#6 0x0000000100044367 in uv_default_loop () at core.c:196 d5#7 0x0000000100004625 in node::Init (argc=1606417456, argv=0x100b0f490) at node.cc:2761 d5#8 0x000000010000797d in node::Start (argc=1606417600, argv=0x0) at node.cc:2888 d5#9 0x0000000100000ca4 in start () This reverts commits: b49d6f7 unix: fix uv_set_process_title() a9f6f06 unix: fix format string vulnerability in freebsd.c a87abc7 unix: avoid buffer overflow in proctitle.c dc97d44 unix: move uv_set_process_title() to proctitle.c
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a few compile checks to make it a bit easier to compile for OSX. After getting gcc 4.6 compiled this was all that was needed to compile and run the sample webserver. May help address #1