Fix get_abs_basis_set when basis set is unknown and trust_me is True#17
Merged
Conversation
Fix utilities.get_abs_basis_set() so that an unknown basis_set is returned if trust_me is True. Old version just returned the last element of BASIS_SET_EXCHANGE_KEY, picked up from the preceding for loop.
Collaborator
|
Sorry for the delay, I missed the notification. Thanks for the fix! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a bug in utilities.get_abs_basis_set() that returned the last element of BASIS_SET_EXCHANGE_KEY, picked up from the preceding for loop, if basis_set is unknown and trust_me is True.