Open
Conversation
Author
|
Oh, I'll fix that today. |
Codecov Report
@@ Coverage Diff @@
## master #43 +/- ##
==========================================
+ Coverage 94.17% 94.33% +0.16%
==========================================
Files 5 5
Lines 103 106 +3
Branches 31 31
==========================================
+ Hits 97 100 +3
Misses 6 6
Continue to review full report at Codecov.
|
Author
|
Hey @ctrlplusb will this be considered at all? Will be using this in production soon, would be nice to have this fixed. |
|
Hi @ctrlplusb @DPr00f ! Thanks for reporting this issue. I ran into the same thing with the error component on SSR. Any updates if this is going to be resolved? Many thanks for all your work on this library. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As explained on #29 the Error component wasn't being rendered on the server side.
This PR fixes it.