Let define syntax for extensions; Fix #6#7
Merged
tonyganch merged 2 commits intocsscomb:devfrom Sep 27, 2015
isqua:issues/6
Merged
Let define syntax for extensions; Fix #6#7tonyganch merged 2 commits intocsscomb:devfrom isqua:issues/6
tonyganch merged 2 commits intocsscomb:devfrom
isqua:issues/6
Conversation
Member
|
Here: https://github.com/csscomb/core/blob/dev/src/core.js#L135 |
Member
It is. Thank you 🐘 |
Contributor
Author
|
🆙 |
test/core.js
Outdated
Member
There was a problem hiding this comment.
You can't be sure that map was copied because {} is the default value it gets even if configuration fails.
I'd offer replacing on line 27 syntax: {} with syntax: {'.css': 'scss'}, for example.
Contributor
Author
There was a problem hiding this comment.
assert.equal check pointers, not values:
assert.equal({}, {}); // => false
let a = {};
let b = a;
assert.equal(a, b); // true...
Contributor
Author
|
Is Map usage ok? If so, I’ll squash commits. |
Member
|
Map is ok. Let me know when to merge. |
Contributor
Author
|
It’s ready to merge now 🔥 |
Member
|
Thank you very much 👯 |
Contributor
Author
|
When csscomb.js will support this feature? |
|
I'm interested in this feature too |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Discussion: #6
In
.csscomb.json:{ "syntax": { ".css": "scss", ".lss": "less" } }If the implementation is ok, I’ll write tests.