Fix and clarify the milliseconds parsing test#108
Merged
Conversation
brynrhodes
approved these changes
May 17, 2026
ewoutkramer
approved these changes
May 17, 2026
Contributor
ewoutkramer
left a comment
ewoutkramer
left a comment
There was a problem hiding this comment.
Although "xx.10000" would be a correct output too, the test's "xx.100" is also correct, per the equality semantics (which is used to compare the output of the test).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #99.
In time literals, ".XXXXX" represents fractional seconds and more than three digits should be allowed.