Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
related to #305
resolves #313
Python venv fix
Apparently,
uvrespects theUV_PROJECT_ENVIRONMENTenv var for only certainuvcommands.This workaround involves a combination of
--projectand--directory:Where
(pwd)is the nushell builtin command similar to bash's$(pwd)and should point to the working directory.Tested in a container
I ran this in the test repo using the
ubuntu:latestdocker image (for Linux runners only).While it works now (after switching from bash to nushell), I found that the LLVM script requires certain tools that are not present in docker images.
So after a lot of trial and error, I revised the README to describe the required tools for each platform. It turns out nushell's builtin
httpcommand usescurlorwgetunderneath (on Linux).sudois no longer required if the docker container runs as root. 🎉Summary by CodeRabbit
Documentation
cache-enabledescription to explain caching behavior, defaults, and cache location.Refactor
Chores