feat: add dropdown menu#97
Merged
Merged
Conversation
wendyyuchensun
force-pushed
the
dropdown-menu
branch
from
b9b74a6 to
e1616e5
Compare
andy19910102
requested review from
WendellLiu
and removed request for
WendellLiu
jamliaoo
reviewed
Mar 14, 2026
Comment on lines
+21
to
+40
| <a | ||
| href={item.href} | ||
| target="_blank" | ||
| rel="noopener noreferrer" | ||
| className={cn( | ||
| 'block w-full px-3 py-2 text-sm leading-[1.4] text-text-primary text-left', | ||
| active ? 'bg-bg-main' : 'bg-white' | ||
| )} | ||
| > | ||
| <span>{item.label}</span> | ||
| </a> | ||
| ) : ( | ||
| <button | ||
| type="button" | ||
| onClick={item.onClick} | ||
| className={cn( | ||
| 'w-full px-3 py-2 text-sm leading-[1.4] text-text-primary text-left', | ||
| active ? 'bg-bg-main' : 'bg-white' | ||
| )} | ||
| > |
Collaborator
There was a problem hiding this comment.
a 的 className 比 button 多了 block，兩邊需要一至嗎～？
Collaborator
Author
There was a problem hiding this comment.
這邊希望 dropdown 裡的每個 anchor/button 會占滿一行。
因為 anchor 原本預設的 display mode 是 inline，所以才加了 block 讓它可以占滿一行。
button 則是預設 display mode 是 inline-block，所以不需要改成 block，用了 w-full 後就會占滿一行 :)
jamliaoo
approved these changes
Mar 17, 2026
Collaborator
Author
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Figma: https://www.figma.com/design/nAK7djdtFJ9vfXLo6Yq4r4/%E6%95%B8%E5%AD%B8%E5%85%AC%E5%BC%8F?node-id=905-3293&t=ouVD0DIIj0vtBUva-4
之後會用在 header 的「語言」、「更多」兩處，以及預覽區切換「白底黑字/黑底白字」。