fix: handle undefined id in heading insertion check#77
Merged
Conversation
WendellLiu
approved these changes
Nov 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a crash when inserting images through the upload modal by adding optional chaining to handle cases where insertLatex is called without an id property.
Problem
The insertLatex function in home.js:170 attempted to call
.startsWith('heading')on an id that could beundefined, causing a runtime error and crashing the application when inserting images.Root cause: The image upload handler calls insertLatex without providing an id property:
Access8MathWeb/src/components/edit-icons-tab.js
Lines 31 to 34 in 922247c
When insertLatex attempts to check if
id.startsWith('heading'), it throws:TypeError: Cannot read property 'startsWith' of undefined.Solution
(?.)to safely check if id exists before calling.startsWith().id: 'insert_image_file'to theinsertLatexcall in the image upload handler to provide a proper identifier for image insertion operations.