Skip to content

fix: group radio inputs with fieldset and legend#132

Merged
wendyyuchensun merged 1 commit into
coseeing:mainfrom
wendyyuchensun:radio-fieldset
May 12, 2026
Merged

fix: group radio inputs with fieldset and legend#132
wendyyuchensun merged 1 commit into
coseeing:mainfrom
wendyyuchensun:radio-fieldset

Conversation

@wendyyuchensun

@wendyyuchensun wendyyuchensun commented May 11, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Replaced the <div> + <span> wrapper in RadioGroup with <fieldset> + <legend> so screen readers announce the group name with each radio option.
  • Renamed the label prop to legend to match the underlying element, and made it required — every radio group should have an accessible group name.
  • Updated the LinkInputModal call site to use the new prop name.

@wendyyuchensun wendyyuchensun changed the title fix: group radio inputs with fieldset fix: group radio inputs with fieldset and legend May 11, 2026
@wendyyuchensun wendyyuchensun merged commit 93cf909 into coseeing:main May 12, 2026
1 check passed
@wendyyuchensun wendyyuchensun deleted the radio-fieldset branch May 12, 2026 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants