Conversation
…go build) to .gitignore. Specify int64 where necessary.
crfeliz
force-pushed
the
update_dependencies
branch
from
2e8f4f5 to
30672ab
Compare
|
@squat I know this is quit a large change set. What it boils down to is running a glide upgrade and changing int to int64 in a few places. Could you offer some guidance on how to get this upgrade approved for upstream? I have a few other feature-based changes I hope to push up as well however this upgrade is prerequisite. |
|
Bumping this issue. Let me know if there is anything I can do to to get this change review/merged. I know i looks daunting but this is pretty much the result of running |
|
|
||
| bin/ | ||
| .idea/ | ||
| issue-sync |
There was a problem hiding this comment.
Hmm this should not be here. All binaries should be compiles directly in `bin. If not, we have some build system bug
There was a problem hiding this comment.
yea it currently builds in the same directory as source. I can look into that. I'll remove this from the pr.
| .glide/ | ||
|
|
||
| bin/ | ||
| .idea/ |
There was a problem hiding this comment.
This is for some editor files?
There was a problem hiding this comment.
Yes. I use IntelliJ which creates editor files under that directory.
| // matches[0] is the whole string, matches[1] is the ID | ||
| matches := jCommentIDRegex.FindStringSubmatch(jComment.Body) | ||
| id, _ := strconv.Atoi(matches[1]) | ||
| id, _ := strconv.ParseInt(matches[1], 10, 64) |
There was a problem hiding this comment.
Not from this PR,but we need to give this module some TLC and check all returned errors.
There was a problem hiding this comment.
Yep. My upcoming PRs add features as well as more thorough error handling and I'm currently working on unit tests. It might prove difficult to slice the upcoming work into small PRs (I'll do my best obviously) but included in those changes are some minor improvements in various parts of the code.
|
Hmm that’s too bad yes let’s plz tackle that.
…On Friday, May 10, 2019, Carlos R. Feliz ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In .gitignore
<#46 (comment)>:
> @@ -14,3 +14,5 @@
.glide/
bin/
+.idea/
+issue-sync
yea it currently builds in the same directory as source. I can look into
that. I'll remove this from the pr.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#46 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AE4JAP2H6NMPGPIMYI225JLPUXQWRANCNFSM4HHSQP2Q>
.
|
2 participants
#45
Update all dependencies. Add
.ideaandissue-sync(output ofgo build) to .gitignore. Specify int64 where necessary.