Create API client objects#15
Create API client objects#15MorganEPatch merged 1 commit intocoreos:masterfrom MorganEPatch:client-classes
Conversation
|
This isn't ready for review yet. I've been testing with dry runs, which do work just fine here, but there seems to be a bug causing crashes when run for real. |
|
@LyonesGamer Ok. Please let me know if you need a hand. I would be happy to help you debug. |
|
@squat Should be fixed now. The issue is that the endpoints to create or update a JIRA issue return an issue object, but I didn't realize that object only has the key and ID set. So I need to call GET after a create or update in order to have the complete issue object. |
There was a problem hiding this comment.
@LyonesGamer overall this looks great. It nicely abstracts the logic from the rest of the library into new types. To clean this up further, it would be good to put the individual client go files into the lib package or a sub-package. The functions in these files are really dependencies of the library code and are not very useful as a standalone package. So after this we would have:
└── lib
├── clients
│ ├── jira.go
│ └── github.go
├── comments.go
├── issues.go
└── ...
squat
left a comment
squat
left a comment
There was a problem hiding this comment.
Cool let's merge this and iterate further.
Group the GitHub and JIRA functions into client API object which wrap the library APIs. This hides the details of the GitHub and JIRA APIs from the rest of the library, and allows us to create multiple clients for dry runs and test mocking.
2 participants
Depends on #14.
Group the GitHub and JIRA functions into client API objects which wrap the library APIs. This hides the details of the GitHub and JIRA APIs from the rest of the library, and allows us to create multiple clients for dry runs and test mocking.
@squat