Replace iptables-legacy by iptables-nft#4526
Merged
Merged
Conversation
Matches what we are using in FCOS and the general default in Fedora.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request replaces the iptables package with iptables-nft across the configuration files and initialization scripts. The changes include updates to rpms.in.yaml, src/vmdeps.txt, and src/supermin-init-prelude.sh. A review comment suggests refactoring the update-alternatives commands in the shell script into a loop to reduce code duplication and improve maintainability.
jbtrystram
approved these changes
Apr 8, 2026
|
|
||
| # /usr/sbin/ip{,6}tables is installed as a symlink to /etc/alternatives/ip{,6}tables but | ||
| # the /etc/alternatives symlink to /usr/sbin/ip{,6}tables-legacy is missing. This recreates | ||
| # the missing link. Hehe. |
Member
|
This LGTM, but I wonder.. is this even needed at all? I guess when we run podman it tries to do things with |
dustymabe
approved these changes
Apr 8, 2026
Member
Author
|
I don't really know if it's needed but it might a dependency for podman and thus it would be difficult to remove. I went for the smallest fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Matches what we are using in FCOS and the general default in Fedora.