org.opencontainers.ref.name -> org.opencontainers.image.ref.name#278
Merged
runcom merged 2 commits intocontainers:masterfrom May 26, 2017
Merged
org.opencontainers.ref.name -> org.opencontainers.image.ref.name#278runcom merged 2 commits intocontainers:masterfrom
runcom merged 2 commits intocontainers:masterfrom
Conversation
Signed-off-by: Akihiro Suda <suda.akihiro@lab.ntt.co.jp>
Contributor
Author
|
CI failure seems unrelated |
Member
|
Thanks a lot for spotting this @AkihiroSuda - actually CI failure is related to the fact that we vendor latest containers/storage master and that introduced toml dep what we're not vendoring. Could you please add it to vendor.conf (do not run |
Signed-off-by: Akihiro Suda <suda.akihiro@lab.ntt.co.jp>
Contributor
Author
|
done |
Member
Member
|
@AkihiroSuda would you open a PR in skopeo to vendor c/image master over there to pull in this change? 👼 |
runcom
reviewed
May 26, 2017
|
|
||
| annotations := make(map[string]string) | ||
| annotations["org.opencontainers.ref.name"] = d.ref.tag | ||
| annotations["org.opencontainers.image.ref.name"] = d.ref.tag |
Member
There was a problem hiding this comment.
actually, I'd rather use what's defined in oci image-spec itself, I'll follow up on this.
Member
There was a problem hiding this comment.
nevermind, they're not defined anywhere lol
Contributor
Author
There was a problem hiding this comment.
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to rc6 spec, the annotation was wrong https://github.com/opencontainers/image-spec/blob/v1.0.0-rc6/annotations.md
Signed-off-by: Akihiro Suda suda.akihiro@lab.ntt.co.jp