chore(release): separate out comment step#168
Merged
Conversation
This helps me scope the permissions more narrowly.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the release automation workflows to better scope credentials/permissions by moving the “prepared release” issue comment out of the PR-upsert script and into the workflow, and by explicitly requesting specific permissions for the GitHub App installation token.
Changes:
- Add explicit requested permissions to the GitHub App token creation step in release workflows.
- Move the “Prepared release PR…” issue comment from
.github/scripts/upsert-release-pr.shinto therelease-prepareworkflow. - Remove the now-redundant issue comment logic from the PR upsert script.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
.github/workflows/release-publish.yml |
Requests contents: write on the GitHub App token used for publishing. |
.github/workflows/release-prepare.yml |
Requests contents/pull-requests: write on the GitHub App token and adds a separate workflow step to comment on the prepared release. |
.github/workflows/release-branch.yml |
Requests contents: write on the GitHub App token used for branch creation. |
.github/scripts/upsert-release-pr.sh |
Removes the issue comment side-effect so the script only manages the PR. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This helps me scope the permissions more narrowly.